Skip to content

Add infrastructure enrichment tranche#15

Merged
Svaag merged 1 commit into
mainfrom
chore/infrastructure-enrichment
Jun 23, 2026
Merged

Add infrastructure enrichment tranche#15
Svaag merged 1 commit into
mainfrom
chore/infrastructure-enrichment

Conversation

@Svaag

@Svaag Svaag commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add proposed source-cited OpenRouter LLM infrastructure enrichment for AS215932 hosts, routing, monitoring, deployment pins, and loop-local Knowledge MCP infrastructure
  • refresh targeted infrastructure/deployment/monitoring source concepts, including loop Knowledge MCP, routed Docker IPv6, and loop_docker_subnet
  • add canonical Deployment concepts and A0 pinned_to claims for knowledge_mcp_version and noc_knowledge_version
  • include deployment concepts in infrastructure source packs and trigger infrastructure advisory synthesis for Knowledge MCP/Docker IPv6/monitoring topology tasks
  • add reviewed curated policy separating three OpenRouter credential scopes: CI/CD PR-Agent, Engineering Loop runtime, and Knowledge Loop enrichment
  • add grounding/retrieval eval coverage for infrastructure advisory synthesis and OpenRouter key ownership
  • make observed-state unit coverage deterministic so committed time-bounded observations can expire without date-flaky tests

Enrichment

  • okf/generated/enriched/infrastructure.md
  • provider: openrouter
  • model: anthropic/claude-sonnet-4.6
  • mode: llm
  • review_status: proposed
  • authority: advisory
  • dispute_policy: repo_wins

Credential-scope note

The GitHub org-level Actions secret named OPENROUTER_API_KEY is documented as CI/CD PR-Agent scope. The Engineering Loop OpenRouter key and Knowledge Loop OpenRouter key are separate Vault-backed credentials. Knowledge enrichment must use the dedicated Knowledge Loop enrichment key, not the CI/CD key and not the Engineering Loop runtime key.

Validation

  • uv run ruff check src tests
  • uv run mypy --strict src
  • uv run pytest
  • uv run hyrule-knowledge validate okf
  • uv run hyrule-knowledge quality --check
  • uv run hyrule-knowledge export --check
  • uv run hyrule-knowledge eval --check
  • uv run hyrule-knowledge ledger --check
  • uv run hyrule-knowledge ledger lifecycle --check
  • uv run hyrule-knowledge scan-secrets okf exports reports evals ledger schema

Eval

  • 51/51 evals passed
  • 59 tests passed
  • adds grounding-010-infrastructure-enrichment
  • adds retrieval-016-openrouter-key-ownership

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b2600456db

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/hyrule_knowledge/context_pack.py
Comment thread reports/coverage.json Outdated
@Svaag Svaag force-pushed the chore/infrastructure-enrichment branch from b260045 to de65411 Compare June 23, 2026 11:04

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: de65411d85

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread exports/manifest.json Outdated
@Svaag Svaag force-pushed the chore/infrastructure-enrichment branch 2 times, most recently from dadcaa9 to 0f0b135 Compare June 23, 2026 11:23

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0f0b135db8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread okf/generated/infrastructure/hosts/loop.md
@Svaag Svaag force-pushed the chore/infrastructure-enrichment branch from 0f0b135 to fc4b1bf Compare June 23, 2026 11:28

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fc4b1bfc54

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/hyrule_knowledge/retrieval.py
Comment thread okf/generated/monitoring/network-operations-monitoring.md
@Svaag Svaag force-pushed the chore/infrastructure-enrichment branch 2 times, most recently from 6b1e315 to 278b772 Compare June 23, 2026 11:40
@Svaag

Svaag commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 278b77215d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/hyrule_knowledge/retrieval.py Outdated
@Svaag Svaag force-pushed the chore/infrastructure-enrichment branch from 278b772 to 6d09592 Compare June 23, 2026 11:49
@Svaag

Svaag commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6d09592c0a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread reports/quality.jsonl Outdated
@Svaag Svaag force-pushed the chore/infrastructure-enrichment branch from 6d09592 to e97a4da Compare June 23, 2026 11:58
@Svaag

Svaag commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e97a4daf8a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/hyrule_knowledge/retrieval.py Outdated
Comment thread okf/generated/infrastructure/prefixes/loop-docker-subnet.md
Comment thread src/hyrule_knowledge/builder.py
@Svaag Svaag force-pushed the chore/infrastructure-enrichment branch from e97a4da to 39c97e8 Compare June 23, 2026 12:08
@Svaag

Svaag commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 39c97e866b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/hyrule_knowledge/retrieval.py Outdated
Comment thread src/hyrule_knowledge/retrieval.py Outdated
@Svaag Svaag force-pushed the chore/infrastructure-enrichment branch from 39c97e8 to afcfdf8 Compare June 23, 2026 12:17
@Svaag

Svaag commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: afcfdf8b6f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/hyrule_knowledge/retrieval.py
@Svaag Svaag force-pushed the chore/infrastructure-enrichment branch from afcfdf8 to 638e5c2 Compare June 23, 2026 12:25
@Svaag

Svaag commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 638e5c2e06

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Svaag Svaag merged commit ae40865 into main Jun 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant