Skip to content

Loop canary: document notification smoke path#21

Merged
Svaag merged 1 commit into
mainfrom
hyrule-feature/ISSUE_ENGINEERING_LOOP_19/engineering-loop
Jun 21, 2026
Merged

Loop canary: document notification smoke path#21
Svaag merged 1 commit into
mainfrom
hyrule-feature/ISSUE_ENGINEERING_LOOP_19/engineering-loop

Conversation

@hyrule-engineering-loop

Copy link
Copy Markdown
Contributor

Change class

app_feature

Repos touched

  • engineering-loop

Senior role reviews

  • network_architect: not approved
  • systems_engineer: approved
  • devops_netops: approved
  • security_auditor: not approved
  • finops_integrity: not approved
  • virtual_lab_chaos: not approved

Source-of-truth files consulted

  • engineering-loop:README.md

Validation gates run

  • ['/opt/engineering-loop/.venv/bin/python3', '-c', 'import json\nfrom pathlib import Path\nfor raw in json.loads('["docs/engineering-loop/notification-smoke-path.md"]'):\n path = Path(raw)\n if not path.exists():\n continue\n if not path.is_file():\n raise SystemExit(f'not a file: {raw}')\n path.read_text(encoding='utf-8')\n']: unknown

Expected production impact

none

Rollback plan

Discard the generated feature worktree and branch; no production state was changed.

NOC handoff

  • handoff artifact: /var/lib/engineering-loop/runs/issue_engineering_loop_19/handoff/noc_handoff.json
  • rollback trigger: operator rejection, failed gates, or failed post-deploy checks
  • expected duration: none

Post-deploy checks

  • review graph state
  • run documented gates

Operator notes

Closes #19

@Svaag Svaag marked this pull request as ready for review June 21, 2026 14:54
@Svaag Svaag merged commit 9396fab into main Jun 21, 2026
4 checks passed
@Svaag Svaag deleted the hyrule-feature/ISSUE_ENGINEERING_LOOP_19/engineering-loop branch June 21, 2026 14:54

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8e9aa819eb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

1. **Discord webhook** — a short summary showing the run result
(success, stuck, or over-budget), the change class, the risk tier,
and iteration/wall-clock stats.
2. **Icinga passive check** — the daemon submits `loop!engineering-loop`

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Correct the documented Icinga check name

The daemon does not submit to loop!engineering-loop: notify_icinga defaults HYRULE_ICINGA_CHECK to noc!engineering-loop, and the existing architecture notes describe the same service. When a NOC operator follows this smoke path without overriding that environment variable, they will inspect or configure the wrong Icinga service and miss whether the daemon heartbeat is actually reporting, so this should either use noc!engineering-loop or explicitly document the required override.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Loop canary: document notification smoke path

1 participant