Loop canary: document notification smoke path#21
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8e9aa819eb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 1. **Discord webhook** — a short summary showing the run result | ||
| (success, stuck, or over-budget), the change class, the risk tier, | ||
| and iteration/wall-clock stats. | ||
| 2. **Icinga passive check** — the daemon submits `loop!engineering-loop` |
There was a problem hiding this comment.
Correct the documented Icinga check name
The daemon does not submit to loop!engineering-loop: notify_icinga defaults HYRULE_ICINGA_CHECK to noc!engineering-loop, and the existing architecture notes describe the same service. When a NOC operator follows this smoke path without overriding that environment variable, they will inspect or configure the wrong Icinga service and miss whether the daemon heartbeat is actually reporting, so this should either use noc!engineering-loop or explicitly document the required override.
Useful? React with 👍 / 👎.
Change class
app_feature
Repos touched
Senior role reviews
Source-of-truth files consulted
Validation gates run
Expected production impact
none
Rollback plan
Discard the generated feature worktree and branch; no production state was changed.
NOC handoff
Post-deploy checks
Operator notes
Closes #19