Feature/merge prs#44
Merged
vinaayakh-aot merged 30 commits intoMay 14, 2026
Merged
Conversation
…ll_action, add default-deny scope policy mode, and filter tools/list by caller scopes.
…nto feature/merge-prs
…e-connector' into feature/merge-prs
…tection-and-code-quality-analysis' into feature/merge-prs
rahul-aot
approved these changes
May 13, 2026
rahul-aot
reviewed
May 13, 2026
|
|
||
|
|
||
| def _resolve_breaker( | ||
| breaker: CircuitBreaker | Callable[[], CircuitBreaker], |
Collaborator
There was a problem hiding this comment.
Identified an issue in _resolve_breaker where pybreaker.CircuitBreaker instances were incorrectly treated as callable factory functions since CircuitBreaker objects are themselves callable. This caused the breaker instance to be replaced with a wrapper function, leading to 'function' object has no attribute 'state' errors during resilience checks.
Fix :
def _resolve_breaker(
breaker: CircuitBreaker | Callable[[], CircuitBreaker],
) -> CircuitBreaker:
if isinstance(breaker, CircuitBreaker):
return breaker
return breaker() if callable(breaker) else breaker
reported by - @kesav-aot
kesav-aot
approved these changes
May 14, 2026
rahul-aot
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge PRs and resolved conflicts for.
#37
#25
#24
#21
#20
#16