Skip to content

fix: correct package_data paths for native library files (closes #228)#229

Open
botbikamordehai2-sketch wants to merge 1 commit into
1Password:mainfrom
botbikamordehai2-sketch:fix/issue-228-1780831143
Open

fix: correct package_data paths for native library files (closes #228)#229
botbikamordehai2-sketch wants to merge 1 commit into
1Password:mainfrom
botbikamordehai2-sketch:fix/issue-228-1780831143

Conversation

@botbikamordehai2-sketch

Copy link
Copy Markdown

What

The get_shared_library_data_to_include() function in setup.py returns relative paths (e.g., lib/x86_64/libop_uniffi_core.so) that are not resolved correctly by setuptools' package_data when package_dir is set to {'': 'src'}. This causes the native library and bindings to be missing from the installed package, leading to import errors (e.g., ModuleNotFoundError: No module named 'onepassword.lib').

Fix

Prefix the returned file paths with the package name onepassword/ so that setuptools correctly locates the files under src/onepassword/lib/... and includes them in the wheel.

Closes #228

@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

environments.py:get_variables() in v0.4.1b1 seems broken

1 participant