Skip to content

chore(typecheck): exclude standalone Expo example#28

Merged
taylanpince merged 1 commit into
masterfrom
exclude-expo-example-typecheck
Jun 10, 2026
Merged

chore(typecheck): exclude standalone Expo example#28
taylanpince merged 1 commit into
masterfrom
exclude-expo-example-typecheck

Conversation

@tolgahan-arikan

Copy link
Copy Markdown
Collaborator

Summary

  • exclude the standalone Expo example from the root TypeScript project
  • keep Expo example typechecking on its separate npm-based path

Why

examples/expo-example is intentionally outside the Yarn workspace, so root yarn install does not install its npm dependencies. Without this exclusion, root yarn typecheck can fail on clean checkouts with missing Expo-only dependencies like expo-web-browser.

Verification

  • yarn typecheck
  • yarn typecheck --listFilesOnly does not include examples/expo-example
  • npm --prefix examples/expo-example run typecheck

@tolgahan-arikan tolgahan-arikan requested a review from a team June 10, 2026 15:26
@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown

Claude finished @tolgahan-arikan's task —— View job


PR Review: Exclude Expo Example from TypeScript Checking ✅

Todo List:

  • Read and analyze the tsconfig.json changes
  • Verify alignment with project structure and documented approach
  • Check conventional commits format compliance
  • Assess potential impacts and edge cases
  • Provide comprehensive review feedback

Review Summary

✅ LGTM - This is a clean, well-reasoned fix!

Analysis

TypeScript Configuration Change:

  • File: tsconfig.json:30
  • Change: Added "examples/expo-example" to the exclude array
  • Impact: Root yarn typecheck will no longer attempt to type-check the Expo example

Validation

Correctness of TypeScript API surface changes:

  • No changes to src/index.tsx - API surface remains unchanged
  • No impact on published library types or exports

API.md updates:

  • Not required - no changes to public API exports in src/index.tsx

Native layer consistency:

  • Not applicable - this is purely a TypeScript configuration change
  • No android/ or ios/ modifications needed

Conventional Commits format:

  • Commit message: chore(typecheck): exclude standalone Expo example
  • ✅ Proper format: type(scope): description
  • ✅ Appropriate type: chore for build/tooling changes
  • ✅ Clear, descriptive scope: typecheck

Alignment with project architecture:

  • Perfectly aligned with documented approach in AGENTS.md
  • package.json:99 confirms !examples/expo-example workspace exclusion
  • package.json:31 shows expo-example uses packageManager: npm@10.9.7
  • Root yarn workspace intentionally excludes expo-example to maintain npm independence

Technical Rationale

This change addresses a real pain point where:

  1. Problem: examples/expo-example is intentionally outside the Yarn workspace (uses npm)
  2. Issue: Root yarn install doesn't install expo-example's npm dependencies
  3. Symptom: yarn typecheck fails on clean checkouts due to missing Expo dependencies like expo-web-browser
  4. Solution: Exclude expo-example from root TypeScript checking while preserving its independent npm-based typecheck via npm --prefix examples/expo-example run typecheck

No Issues Found

  • No bugs or edge cases identified
  • Change is minimal and surgical
  • Maintains expo-example's independence while fixing the typecheck issue
  • No security implications
  • No breaking changes

Recommendation

Approve and merge. This is a well-thought-out infrastructure fix that properly aligns the TypeScript configuration with the intended project architecture.


@taylanpince taylanpince merged commit 65b591a into master Jun 10, 2026
7 checks passed
@tolgahan-arikan tolgahan-arikan deleted the exclude-expo-example-typecheck branch June 10, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants