Fix integrated terminal PTY on Linux - #36
Draft
eladrave wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node-ptyas a host-native dependencynode-ptybundled in the downloaded desktop ASARnode-ptyfor Nix packagesWhy
The desktop archive is downloaded from the macOS arm64 build. Its bundled
node-ptynative module cannot load on Linux, so opening the integrated terminal fails. Resolvingnode-ptyfrom the host installation provides a native module for the actual runtime platform.Validation
npm run preparenpm run build:browsernpm run build:servernpm run test:ptyon macOSnpm run test:ptylinux/amd64Node container install followed bynpm run test:ptyThis PR intentionally contains no Cloud Run, GCS, IAP, SSH, container deployment, or deployment-documentation changes.