Skip to content

as per request#160

Merged
tboggs merged 6 commits into
spectralpython:developfrom
YannChemin:master
Aug 9, 2024
Merged

as per request#160
tboggs merged 6 commits into
spectralpython:developfrom
YannChemin:master

Conversation

@YannChemin

@YannChemin YannChemin commented Oct 17, 2023

Copy link
Copy Markdown
Contributor

Loads Relab library basic info, does not load type, class and subclass
some code using ignorefiles is not needed

@LaurentBerder

LaurentBerder commented Jun 10, 2024

Copy link
Copy Markdown

@tboggs, I have extensively tested it, and it works very well.
Can we merge it in the master?

@YannChemin

Copy link
Copy Markdown
Contributor Author

Hi @tboggs, any update on this side?

@tboggs

tboggs commented Jul 31, 2024

Copy link
Copy Markdown
Member

Hi @YannChemin, apologies for the delay. I'm away from my dev system for a few days. I'll review & test this by next week.

@tboggs

tboggs commented Aug 5, 2024

Copy link
Copy Markdown
Member

The code looks good to me but before merging to master, please add some basic unit tests for creating and querying a Relab database. You should be able to copy most of the test code from one of the other databases in this file (you can also add the unit tests to the same file).

@YannChemin

Copy link
Copy Markdown
Contributor Author

This is done, test added

@YannChemin

Copy link
Copy Markdown
Contributor Author

@tboggs

@tboggs

tboggs commented Aug 7, 2024

Copy link
Copy Markdown
Member

@YannChemin Thanks for adding the unit tests. I will have time to test the code in the next day or two and merge into master.

In the meantime, could you please rename the relabDatabase class to RelabDatabase to maintain pep8 compliance for class names?

@YannChemin

Copy link
Copy Markdown
Contributor Author

OK done @tboggs

@tboggs

tboggs commented Aug 9, 2024

Copy link
Copy Markdown
Member

@YannChemin, I'm ready to look at this now. Are PR #158 and #160 identical, just merging to different branches?

@tboggs tboggs merged commit c620527 into spectralpython:develop Aug 9, 2024
neusebio11 pushed a commit to neusebio11/spectral that referenced this pull request Apr 9, 2026
* Add files via upload

* Update relab.py

bug fix

* Add files via upload

* added Relab test

* added Relab init

* rename according to PEP8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants