Skip to content

fix(cli): handle fast terminal process exits#158

Open
VincentShipsIt wants to merge 2 commits into
developfrom
codex/clawpatch-20260523-090217-safe-fixes
Open

fix(cli): handle fast terminal process exits#158
VincentShipsIt wants to merge 2 commits into
developfrom
codex/clawpatch-20260523-090217-safe-fixes

Conversation

@VincentShipsIt
Copy link
Copy Markdown
Contributor

Summary

  • register terminal output/exit listeners before spawning the managed CLI process
  • buffer synchronous output/exit events emitted during spawn
  • avoid attaching stdin/raw mode when the process has already exited
  • add a regression test for synchronous fast-exit behavior

Verification

  • bun --filter @shipshitdev/shipcode test src/commands/terminal.test.ts
  • bunx biome check apps/cli/src/commands/terminal.ts apps/cli/src/commands/terminal.test.ts --files-ignore-unknown=true
  • bun scripts/verify-affected-workspaces.ts

Clawpatch finding addressed: fnd_sig-feat-cli-command-8c1a6ec86c-_e76151cd7f.
Skipped the node-pty optional dependency finding because the safe fix spans package/runtime boundaries and is not a small reviewable patch.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 23, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ffd7a5a4-104e-4d61-b4df-d97564fb198f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/clawpatch-20260523-090217-safe-fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@socket-security
Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedtailwindcss@​4.3.01001008498100
Addedtypescript@​6.0.3100100909690

View full report

@github-actions
Copy link
Copy Markdown

React Doctor

Score: 95 / 100

react-doctor v0.2.3

✔ Select projects to scan › @shipcode/desktop, @shipcode/docs, @shipcode/web, @shipcode/ui
Scanning changes: codex/clawpatch-20260523-090217-safe-fixes → develop

No changed source files in /home/runner/work/shipcode/shipcode/apps/desktop, skipping.

No changed source files in /home/runner/work/shipcode/shipcode/apps/docs, skipping.

No changed source files in /home/runner/work/shipcode/shipcode/apps/web, skipping.

No changed source files in /home/runner/work/shipcode/shipcode/packages/ui, skipping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant