From 2690e295203b46788edca3de9af820f953652c11 Mon Sep 17 00:00:00 2001 From: thedavidmeister Date: Thu, 7 May 2026 12:57:53 +0400 Subject: [PATCH] rename testFlowBasicFlowTime to reflect actual coverage MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The function name and file name suggested a time-related test, but the body has no block.timestamp, no time advancement, no time-bound behaviour. The test asserts that eval2's `writes` array is written to the interpreter store under DEFAULT_STATE_NAMESPACE — a store-write coverage test. Renamed function to `testFlowBasicWritesKvsToStore`. The file `Flow.time.t.sol` is left in place for now; PR #449 (#329) adds two more tests on this file. The file rename to `Flow.store.t.sol` can follow once #449 merges. Closes #422. Co-Authored-By: Claude Opus 4.7 (1M context) --- test/src/concrete/Flow.time.t.sol | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/test/src/concrete/Flow.time.t.sol b/test/src/concrete/Flow.time.t.sol index 055cfa33..6612d331 100644 --- a/test/src/concrete/Flow.time.t.sol +++ b/test/src/concrete/Flow.time.t.sol @@ -9,7 +9,10 @@ import {DEFAULT_STATE_NAMESPACE} from "rain.interpreter.interface/interface/IInt import {IInterpreterStoreV2} from "rain.interpreter.interface/interface/IInterpreterStoreV2.sol"; contract FlowTimeTest is FlowTest { - function testFlowBasicFlowTime(uint256[] memory writeToStore) public { + /// `flow()` writes the eval2 `writes` array to the interpreter store + /// under `DEFAULT_STATE_NAMESPACE`. (No time semantics — see file + /// note above the contract.) + function testFlowBasicWritesKvsToStore(uint256[] memory writeToStore) public { vm.assume(writeToStore.length != 0); (IFlowV5 flow, EvaluableV2 memory evaluable) = deployFlow();