Likely wrong reference on irradiance.reindl

[ramaroesilva]

In irradiance.reindl, two references are cited for this function. I believe that [1] is a wrong reference, since it corresponds to a decomposition paper. However, from a paragraph within that same paper (see printscreen below), I'm almost sure the original idea was to cite Reindl's thesis, which addresses both decomposition and transposition.

To Reproduce
Steps to reproduce the behavior:

1. Go to [1] in irradiance.reindl

Expected behavior
Replace [1] url with https://web.archive.org/web/20240709013622/https://minds.wisconsin.edu/bitstream/handle/1793/47852/0001.pdf

Screenshots
From Reindl's decomposition paper:

[ramaroesilva]

Since @cbcrespo is playing with transposition functions within her GSOC activity #2750, maybe she could fix this.

Or would you prefer we leave this for another pvlib first-timer?

[AdamRJensen]

Since @cbcrespo is playing with transposition functions within her GSOC activity #2750, maybe she could fix this.

Or would you prefer we leave this for another pvlib first-timer?

If @cbcrespo is up for fixing it, then I think that would be great 😄

[cwhanse]

The misdirected references were ported from PVLib for Matlab, which in turn got them from the Loutzenhiser paper. Nice detective work to locate the correction.

[Omesh37]

Right now, the docstring cites [1] (Reindl 1990a, Diffuse fraction correlations), but that’s actually a decomposition paper. The function irradiance.reindl is a transposition model, which is described in [2] (Reindl 1990b, Evaluation of hourly tilted surface radiation models).

So the correct fix would be to replace [1] with the Reindl 1988 thesis, while keeping [2] and [3] as they are.

Is the right approach, and should I open a PR

[cwhanse]

@Omesh37 Thanks for the offer but @cbcrespo will be editing this and similar functions. That work can correct the references.