Fix case-sensitive Accept header comparison#359
Merged
koic merged 1 commit intoMay 23, 2026
Conversation
## Motivation and Context RFC 9110 defines media type comparison as case-insensitive, but `parse_accept_header` compared types without normalizing case. This caused `Application/JSON` or `TEXT/Event-Stream` to be rejected with 406 Not Acceptable. ## How Has This Been Tested? Added tests for mixed-case Accept headers: - `Accept: Application/JSON, Text/Event-Stream` succeeds for POST - `Accept: TEXT/EVENT-STREAM` succeeds for GET SSE ## Breaking Changes None. This is a bug fix bringing behavior into conformance with RFC 9110.
atesgoral
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
RFC 9110 defines media type comparison as case-insensitive, but
parse_accept_headercompared types without normalizing case. This causedApplication/JSONorTEXT/Event-Streamto be rejected with 406 Not Acceptable.How Has This Been Tested?
Added tests for mixed-case Accept headers:
Accept: Application/JSON, Text/Event-Streamsucceeds for POSTAccept: TEXT/EVENT-STREAMsucceeds for GET SSEBreaking Changes
None. This is a bug fix bringing behavior into conformance with RFC 9110.
Types of changes
Checklist