Warn on implicit stdio initialization#338
Conversation
|
Thanks for the follow-up. Since v0.15.0 was just released, wait a bit before merging and releasing. |
7c0d146 to
b6462fe
Compare
|
@koic Shall we get this in now? |
|
The timing for merging and releasing this Phase 2 is a bit of a balancing act, but the idea was to merge it after roughly a month had passed since the release of https://github.com/modelcontextprotocol/ruby-sdk/releases/tag/v0.15.0, which already included Phase 1. At the same time, delaying it too long would reduce the chance for existing users to become aware of the transition, so it probably makes sense to merge it fairly soon. On the other hand, the final behavior change in Phase 3 will be a breaking change, so it may be better to leave a reasonably long gap after Phase 2 before shipping that one (perhaps around three months?). In any case, it probably makes sense to include this in the next release. Thank you! |
Summary
Implements phase 2 of #334 after the 0.15.0 release.
MCP::Client::Stdio#send_requestperforms the compatibility implicit initialization path.MCP::Client#connectno-warning path.How Has This Been Tested?
dev test-- 847 runs, 2159 assertions, 0 failuresNotes
dev stylecurrently reports existing unrelatedMinitest/AssertEmptyLiteraloffenses in files outside this change. No new offense is reported for the touched files.