Skip to content

handleKill returns nil message — no user feedback on kill success/failure #5

Description

@rajfirke

Problem

handleKill() in internal/app/model.go sends SIGTERM to the selected session's PID but always returns nil as the tea.Msg. The user gets zero feedback on whether the kill succeeded or failed.

On Unix, os.FindProcess never returns an error for any positive PID, so the error check is a dead branch. The real failure point is proc.Signal() which can return ESRCH (process already gone) — this error is discarded.

Suggested Fix

  1. Define a KillDoneMsg type with success/error state
  2. Return it from the Cmd
  3. Handle it in Update to show a brief status message (e.g., "Killed session X" or "Process not found")

Files

  • internal/app/model.go:145-163

Metadata

Metadata

Assignees

No one assigned

    Labels

    UXUser experience improvementenhancementNew feature or request

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions