From fccf71b79835e5d0b712b2a928589e3411f8b34e Mon Sep 17 00:00:00 2001 From: Darien Hernandez Date: Mon, 29 Jun 2026 19:05:42 +0200 Subject: [PATCH 1/2] ci: drop node.dev sanitization step MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit genlayer-node NOD-973 removes the `node.dev` section (its only field, `disableSubscription`, a test-only toggle) entirely from config.yaml.example. Once that lands, `del(.node.dev)` deletes a non-existent path — dead config. Remove the del step and the now-stale trailing yq pipe; the RPC-URL/provider placeholder substitutions are unrelated and stay. Sync the workflows README accordingly. Co-Authored-By: Claude Opus 4.8 (1M context) --- .github/scripts/sanitize-config.sh | 6 ++---- .github/workflows/README.md | 5 ++--- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/.github/scripts/sanitize-config.sh b/.github/scripts/sanitize-config.sh index 229c3939..116ec6fe 100644 --- a/.github/scripts/sanitize-config.sh +++ b/.github/scripts/sanitize-config.sh @@ -20,13 +20,11 @@ fi echo "Sanitizing config file: $CONFIG_FILE" # Use yq to: -# 1. Replace RPC URLs with TODO placeholders -# 2. Delete node.dev section +# Replace RPC URLs / provider with TODO placeholders yq -i ' .rollup.genlayerchainrpcurl = "TODO: Set your GenLayer Chain ZKSync HTTP RPC URL here" | .rollup.genlayerchainwebsocketurl = "TODO: Set your GenLayer Chain ZKSync WebSocket RPC URL here" | - .rollup.provider = "TODO: Set your GenLayer Chain ZKSync provider" | - del(.node.dev) + .rollup.provider = "TODO: Set your GenLayer Chain ZKSync provider" ' "$CONFIG_FILE" echo "Config sanitization completed" diff --git a/.github/workflows/README.md b/.github/workflows/README.md index 03969133..8feeea20 100644 --- a/.github/workflows/README.md +++ b/.github/workflows/README.md @@ -181,13 +181,12 @@ The workflow uses composite actions for code reusability: - `.github/scripts/git-utils.sh` - Branch creation, commit, and push operations - `.github/scripts/version-utils.sh` - Version detection and validation - `.github/scripts/doc-generator.sh` - Wrapper for npm documentation generation -- `.github/scripts/sanitize-config.sh` - Sanitizes config file (replaces URLs, removes dev section) +- `.github/scripts/sanitize-config.sh` - Sanitizes config file (replaces URLs) - `.github/scripts/sanitize-docker-compose.sh` - Removes alloy service and volumes from docker-compose ### Config Sanitization The config sync process includes automatic sanitization using `yq`: -- **URL Replacement**: RPC URLs replaced with TODO placeholders -- **Dev Section Removal**: `node.dev` section is removed +- **URL Replacement**: RPC URLs and provider replaced with TODO placeholders ### Docker Compose Sanitization The docker-compose sync process includes automatic sanitization using `yq` and `sed`: From 48b274c1cf52358a1a113b44fd3c2a2635be2508 Mon Sep 17 00:00:00 2001 From: Darien Hernandez Date: Mon, 29 Jun 2026 19:21:18 +0200 Subject: [PATCH 2/2] docs: mention provider in sanitize-config one-line summary Address CodeRabbit: the "Scripts Used" entry for sanitize-config.sh still said "replaces URLs" while the detailed Config Sanitization section lists provider too. Align the summary. Co-Authored-By: Claude Opus 4.8 (1M context) --- .github/workflows/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/README.md b/.github/workflows/README.md index 8feeea20..3b4dccdb 100644 --- a/.github/workflows/README.md +++ b/.github/workflows/README.md @@ -181,7 +181,7 @@ The workflow uses composite actions for code reusability: - `.github/scripts/git-utils.sh` - Branch creation, commit, and push operations - `.github/scripts/version-utils.sh` - Version detection and validation - `.github/scripts/doc-generator.sh` - Wrapper for npm documentation generation -- `.github/scripts/sanitize-config.sh` - Sanitizes config file (replaces URLs) +- `.github/scripts/sanitize-config.sh` - Sanitizes config file (replaces RPC URLs and provider) - `.github/scripts/sanitize-docker-compose.sh` - Removes alloy service and volumes from docker-compose ### Config Sanitization