Feature request: floors which are already lowered shouldn't make PSTOP sound

[0n-s]

Crispy Doom's sound fixes include a fix for doors that are closed by repeatable triggers from making the closing noise when they're already closed. I'd like to see this implemented for floors which lower with repeatable triggers that don't move any more upon further triggers (e.g. because they already lowered to the lowest adjacent floor and they don't have to do anything else). Currently these still make the PSTOP noise even though triggering those linedefs again does nothing at all.

[fabiangreffrath]

Where in the code would that be?

[0n-s]

For the doors?

crispy-doom/src/doom/p_doors.c

Line 305 in d86157b

if (door->sector->ceilingheight - door->sector->floorheight > 0 || !crispy->soundfix)

[mfrancis95]

Do you have an example map where this happens?

[0n-s]

For Ultimate DOOM: pstop.zip

Here it is happening for plats. I will try to find another place where it happens for a floor, but I think plats are important to include in the scope of the issue too.

[fabiangreffrath]

Could be something like this:

--- a/src/doom/p_plats.c
+++ b/src/doom/p_plats.c
@@ -99,12 +99,14 @@ void T_PlatRaise(plat_t* plat)
        break;
        
       case     down:
+       boolean playsound = (plat->sector->floorheight > plat->low || !crispy->soundfix);
        res = T_MovePlane(plat->sector,plat->speed,plat->low,false,0,-1);
 
        if (res == pastdest)
        {
            plat->count = plat->wait;
            plat->status = waiting;
+           if (playsound)
            S_StartSound(&plat->sector->soundorg,sfx_pstop);
        }
        break;
@@ -207,6 +209,7 @@ EV_DoPlat
            plat->high = sec->floorheight;
            plat->wait = TICRATE*PLATWAIT;
            plat->status = down;
+           if (plat->low < sec->floorheight || !crispy->soundfix)
            S_StartSound(&sec->soundorg,sfx_pstart);
            break;
            

[0n-s]

floors2.zip

Here's the test level, containing (I think) all the line types that shouldn't make a sound either at all, or past the first execution (I trust whoever working on this to be able to tell which is which). And a funny crusher — ignore that. It's pretty essential to inspect the level in an editor and see which line types are used here.

Also note that when PSTOP is fixed, the sectors will be free to make other noises, and they do. Specifically STNMOV, once, and with the right timings. It's rare, but it does happen and it's quite startling when it does, so it should probably be fixed as part of this too.

crispy-doom/src/doom/p_plats.c

Line 60 in a1188c9

if (!(leveltime&7))

Example from the plats code, but basically every reference to sfx_stnmov outside of the menu code open codes this over and over.