Hey!
The README for this action suggests executable-path is a directory (GITHUB_WORKSPACE/bin/), but in reality, the code calls path.dirname() on the provided value (here), so the executable-path should actually be the path to the executable (as per the variable name).
The documentation is currently a bit misleading on that one.
This might be less obvious, and also would beg the question if the user can set the executable name this way?
Would it be better if this was actually the path, and the code would join the cloudsmith binary filename, as in:
const EXECUTABLE_PATH = path.join(core.getInput('executable-path') || path.join(process.env.GITHUB_WORKSPACE, 'bin'), 'cloudsmith');
Hey!
The README for this action suggests
executable-pathis a directory (GITHUB_WORKSPACE/bin/), but in reality, the code callspath.dirname()on the provided value (here), so theexecutable-pathshould actually be the path to the executable (as per the variable name).The documentation is currently a bit misleading on that one.
This might be less obvious, and also would beg the question if the user can set the executable name this way?
Would it be better if this was actually the path, and the code would join the
cloudsmithbinary filename, as in: