instance upgrade-versions vs. instance node versions

[jage]

I feel like this is quite confusions:

$ ./cloudamqp instance upgrade-versions --id 351604
Upgrade versions:
{
  "new_erlang_version": "28.1.1",
  "new_rabbitmq_version": "4.2.2"
}

$ ./cloudamqp instance nodes versions --id 351604
Available versions:
RabbitMQ versions: [4.2.2 4.2.1 4.2.0 4.2.0-rc.1 4.2.0-beta.4 4.2.0-beta.3 4.1.7 4.1.6 4.1.5]
Erlang versions: [27.3.4.6]

• Which one should I use?
• Why is one under nodes and not the other one?
• One gives JSON, the other an interesting list syntax :)
• upgrade-versions sounds like an action, not a query

How can we simplify? :)

For example, maybe

/cloudamqp instance upgrade-versions --id 351604 should be ./cloudamqp instance upgrade-all --dry-run?

There's also a lot of upgrade actions, do we need all? Should be enough with one and ability to specify just rabbit/erlang if that's important.

  upgrade-all        Upgrade RabbitMQ and Erlang
  upgrade-erlang     Upgrade Erlang
  upgrade-rabbitmq   Upgrade RabbitMQ
  upgrade-versions   Fetch upgrade versions

[dentarg]

Yeah this can be a lot simpler. What about there's only cloudamqp instance upgrade.

I think this somewhat ties into #15. I think it is awkward with the --id flag last, when, in my mind, you "select" the instance, then the actions you want to do, with it. Or maybe I'm wrong or we shouldn't look at that now. Just to get more feel for it I'll write three variants in my examples here :)

I was thinking that without any "action", it would print versions (some combo of the info in the two commands you posted output from).

cloudamqp instance <n> upgrade
cloudamqp instance --id <n> upgrade
cloudamqp instance upgrade --id <n>

One concern I have in mind is that upgrade could be seen as the "action", so it is scary to run it. We could have show or list "action" for that?

cloudamqp instance <n> upgrade list
cloudamqp instance --id <n> upgrade list
cloudamqp instance upgrade list --id <n>

Then then obvious ones, this goes to latest? (new_rabbitmq_version)

cloudamqp instance <n> upgrade rabbitmq
cloudamqp instance --id <n> upgrade rabbitmq
cloudamqp instance upgrade rabbitmq --id <n>

cloudamqp instance <n> upgrade erlang
cloudamqp instance --id <n> upgrade erlang
cloudamqp instance upgrade erlang --id <n>

I guess you should be able to pass --version for the broker

cloudamqp instance <n> upgrade rabbitmq --version <v>
cloudamqp instance --id <n> upgrade rabbitmq --version <v>
cloudamqp instance upgrade rabbitmq --id <n> --version <v>