Reflection setting default uses a value from the per-object enum

[cppctamber]

Status:
Confirmed from source

Source version:
Carbon v5.0.0, commit 342fbe595b572070e09b583a03e215011f5924e9

Notes
I do not have a runnable Carbon build, it was caught by a build test on my JS version of trinity.

Source
Eve/EveSpaceScene.cpp:112-113:

int g_eveReflectionMode = EntityComponents::REFLECT_NEVER;
TRI_REGISTER_SETTING( "eveReflectionSetting", g_eveReflectionMode );

Description
REFLECT_NEVER belongs to the per-object ReflectionMode enum in Eve/EveEntity.h:9-15.

Every read of the global setting in ShouldReflect, at EveEntity.cpp:13-33, interprets the value as the separate global ReflectionSetting enum (:17-24).

Both enums are stored through an int, but their values have different human meanings:

REFLECT_NEVER == 3
REFLECTION_SETTING_HIGH == 3