Apollo Kotlin introspection query does not include deprecated input fields

[bobi-obretenov]

Version

4.3.3

Summary

Apollo Kotlin: 4.3.3
Apollo Kotlin Gradle Plugin: com.apollographql.apollo 4.3.3
GraphQL Spec: June 2018+ (supports inputFields(includeDeprecated:) argument)

Apollo Kotlin's built-in introspection query (used by the downloadApolloSchemaFromIntrospection Gradle task) does not pass includeDeprecated: true to inputFields in the introspection query. This causes deprecated input fields to be silently omitted from the downloaded schema, which in turn causes codegen to fail when any .graphql operation file references a deprecated input field.

Steps to reproduce the behavior

No response

Logs

(Your logs here)

[martinbonnin]

Can you share the results of this query:

query PreIntrospectionQuery {
  __schema {
    types {
      __typename
      ...TypeFields
    }
  }
}

fragment TypeFields on __Type {
  name
  fields {
    name
    args {
      name
    }
  }
}

This is the query that Apollo Kotlin uses to detect support for includeDeprecated.

[bobi-obretenov]

Hello, ok, the entire response is quite long but these are the places when this deprecated property is mentioned

... { "__typename": "__Type", "name": "__Type", "fields": [ { "name": "kind", "args": [] }, { "name": "name", "args": [] }, { "name": "description", "args": [] }, { "name": "specifiedByURL", "args": [] }, { "name": "fields", "args": [ { "name": "includeDeprecated" } ] }, { "name": "interfaces", "args": [] }, { "name": "possibleTypes", "args": [] }, { "name": "enumValues", "args": [ { "name": "includeDeprecated" } ] }, { "name": "inputFields", "args": [ { "name": "includeDeprecated" } ] }, { "name": "ofType", "args": [] }, { "name": "isOneOf", "args": [] } ] }, { "__typename": "__Type", "name": "__TypeKind", "fields": null }, { "__typename": "__Type", "name": "__Field", "fields": [ { "name": "name", "args": [] }, { "name": "description", "args": [] }, { "name": "args", "args": [ { "name": "includeDeprecated" } ] }, { "name": "type", "args": [] }, { "name": "isDeprecated", "args": [] }, { "name": "deprecationReason", "args": [] } ] }, { "__typename": "__Type", "name": "__InputValue", "fields": [ { "name": "name", "args": [] }, { "name": "description", "args": [] }, { "name": "type", "args": [] }, { "name": "defaultValue", "args": [] }, { "name": "isDeprecated", "args": [] }, { "name": "deprecationReason", "args": [] } ] }, { "__typename": "__Type", "name": "__EnumValue", "fields": [ { "name": "name", "args": [] }, { "name": "description", "args": [] }, { "name": "isDeprecated", "args": [] }, { "name": "deprecationReason", "args": [] } ] }, { "__typename": "__Type", "name": "__Directive", "fields": [ { "name": "name", "args": [] }, { "name": "description", "args": [] }, { "name": "isRepeatable", "args": [] }, { "name": "locations", "args": [] }, { "name": "args", "args": [ { "name": "includeDeprecated" } ] } ] }

[martinbonnin]

"name": "isOneOf", "args": [] } ] },

This is probably the same issue as #6773.

Are you using the Apollo gateway by any chance?

[bobi-obretenov]

I think yes, we are using

apollo-gateway: version 2.13.3
apollo-server: version 5.5.0
apollo-subgraph: version 2.13.3

Do you know if there is any workaround for this issue. I checked the link you provided but I didn't find a solution

[martinbonnin]

I'll look into adding a workaround in Apollo Kotlin. In the meantime, what you can do is get the schema out of band, using something else than introspection.

[martinbonnin]

Workaround here: #6949

[bobi-obretenov]

Great, thanks! When is this fix expected to be released and is there anything new we have to change in the implementation on our side ?

[martinbonnin]

KotlinConf is happening next week so it's going to be a busy week. Also we're just released 5.0 so it might take a few weeks to make a new release. But in the meantime you can always use the previews

[bobi-obretenov]

I tried to use the fix and included explicitly this dependency "apollo-api-jvm" with version of of the snapshot from yesterday and I am getting basically the same failure as before. But maybe I am doing something wrong, do I need to also use the latest versions of the other dependencies for our Apollo client? I tried that too I switched them from 4.3.3 to 5.0.1 I think but still didn't work