add option to keep v prefix in tag#149
Merged
Merged
Conversation
Signed-off-by: André Bauer <andre.bauer@staffbase.com>
Contributor
|
why is this needed? |
Member
Author
I have a repo where the tags use the "v" prefix. |
Contributor
|
Why not adhere to the global standard and drop the v? |
Member
Author
|
Maybe someone wants to use this on a non staffbase repo ;-) |
Contributor
|
@0x46616c6b what do you think? I lean towards not merging this, as I cannot see a use-case and don't want to maintain it |
kaitimmer
approved these changes
Jun 9, 2026
kaitimmer
left a comment
kaitimmer
left a comment
Contributor
There was a problem hiding this comment.
I think its a bit of a strange option, but if we need it, I'm also fine with merging it.
0x46616c6b
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Checklist