Skip to content

Consider having PlatformProvider as a hard Kotlin class #67

Description

@yevhenii-nadtochii

Please try to make PlatformProvider a plain Kotlin class.

Now it is generated during the build by means of ASM library (see :flogger-platform-generator module). This library uses JVM opcodes, and the whole generation looks quite frightening. For me, it is unclear why we should continue to generate it on the fly when we can use a hard class.

In the current set up, this generation seems unnecessary, as there is no way the generated file would somehow differ on different platforms. We always generate the same file.

Another reason for this generation seems to lie in compatibility with proguard tool, and how this tool detects dependencies. This tool is for Android, and I'm not sure if this problem is relevant for newer versions of Android and the mentioned tool. For example, taking Android 6 (September 2015) or 7 (August 2016) as a bottom bar.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions