Skip to content

JS/MJS extractor minted node ids from absolute paths on 0.9.17 (fixed by 0.9.29; same family as #2250/#2262) #2281

Description

@ThomasB-Github

Version: observed on graphifyy 0.9.17. Re-tested after upgrading to 0.9.29: no longer reproduces (details below). Filing team error: we should have tested latest before opening this. Closing, leaving the report for the record in case the TS case (#2262) benefits from the data.

Original observation (0.9.17)

The JS/MJS extractor minted node ids from absolute paths. Observed id shape:

c_users_thomas_projects_home_assistant_tests_render_parity_bar_meter_test_currentflowbars

Drive letter and home directory baked into the id, so these ids could never match the repo-relative ids other passes derive, every edge referencing them dangled, and the id space differed per machine. On a repo with 21 *.test.mjs files plus ha/www/*.js, 20 of 49 distinct dangling endpoint names were absolute-path JS ids.

Re-test on 0.9.29

Extracting the same tests/render_parity/bar_meter.test.mjs on 0.9.29 produces zero absolute-path-shaped ids and zero dangling references of that shape. Looks fixed by the same work that fixed C# in #2250. #2262 reports TS still affected as of 0.9.29; JS/MJS appears to be resolved.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions