From ea676a56b93205b02d0a2fc3b7dbf75a298466a7 Mon Sep 17 00:00:00 2001 From: Daniel Fernandes Date: Fri, 26 Jun 2026 13:16:11 +0000 Subject: [PATCH 1/3] Only log PUT and POST requests as info --- src/blueapi/service/main.py | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/blueapi/service/main.py b/src/blueapi/service/main.py index 432cc5455..631b62a4a 100644 --- a/src/blueapi/service/main.py +++ b/src/blueapi/service/main.py @@ -594,9 +594,15 @@ def start(config: ApplicationConfig): async def log_request_details( request: Request, call_next: Callable[[Request], Awaitable[StreamingResponse]] ) -> Response: - """Middleware to log all request's host, method, path, status and request and - body""" - log = LOGGER.debug if request.url.path == "/healthz" else LOGGER.info + """Middleware to log request's host, method, path, status and request and + body + + Logs POST and PUT as info, all else as debug.""" + log = ( + LOGGER.info + if request.method == "POST" or request.method == "PUT" + else LOGGER.debug + ) request_body = await request.body() client = request.client or Address("Unknown", -1) log_message = f"{client.host}:{client.port} {request.method} {request.url.path}" From 0d76cbba360815332821f500ae6f4d0a1d92f5c5 Mon Sep 17 00:00:00 2001 From: Daniel Fernandes Date: Fri, 26 Jun 2026 13:48:45 +0000 Subject: [PATCH 2/3] Remove duplicate logs for GET requests --- src/blueapi/service/main.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/blueapi/service/main.py b/src/blueapi/service/main.py index 631b62a4a..0215c12dd 100644 --- a/src/blueapi/service/main.py +++ b/src/blueapi/service/main.py @@ -609,7 +609,8 @@ async def log_request_details( extra = { "request_body": request_body, } - log(log_message, extra=extra) + if request.method != "GET": + log(log_message, extra=extra) response = await call_next(request) log_message += f" {response.status_code}" From a1d0ddcf4f8d7c20c04568b8768e3f9d7235c2b9 Mon Sep 17 00:00:00 2001 From: Daniel Fernandes Date: Fri, 26 Jun 2026 14:11:45 +0000 Subject: [PATCH 3/3] Only log GET requests as debug, all else as info --- src/blueapi/service/main.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/blueapi/service/main.py b/src/blueapi/service/main.py index 0215c12dd..1296bec58 100644 --- a/src/blueapi/service/main.py +++ b/src/blueapi/service/main.py @@ -597,12 +597,8 @@ async def log_request_details( """Middleware to log request's host, method, path, status and request and body - Logs POST and PUT as info, all else as debug.""" - log = ( - LOGGER.info - if request.method == "POST" or request.method == "PUT" - else LOGGER.debug - ) + Logs GET as debug, all else as info.""" + log = LOGGER.debug if request.method == "GET" else LOGGER.info request_body = await request.body() client = request.client or Address("Unknown", -1) log_message = f"{client.host}:{client.port} {request.method} {request.url.path}"