feat(dkg): add EdDSA MPCv2 keygen API spec entries and route stubs to AWM#255
Draft
bitgo-ai-agent-dev[bot] wants to merge 1 commit into
Draft
feat(dkg): add EdDSA MPCv2 keygen API spec entries and route stubs to AWM#255bitgo-ai-agent-dev[bot] wants to merge 1 commit into
bitgo-ai-agent-dev[bot] wants to merge 1 commit into
Conversation
bitgo-ai-agent-dev
Bot
force-pushed
the
WCI-895-eddsa-mpcv2-keygen-callback-factory-pt1
branch
from
cb678cd to
ae2780b
Compare
4 tasks
Add io-ts request/response types and three new route entries to
AdvancedWalletManagerApiSpec for the EdDSA MPCv2 DKG protocol:
- POST /api/{coin}/eddsampcv2/keygen/initialize
- POST /api/{coin}/eddsampcv2/keygen/round1
- POST /api/{coin}/eddsampcv2/keygen/finalize
Each route is wired in createKeyGenRouter with a NotImplementedError
stub; the real handlers land in WCI-892. The type exports are needed
by the ME client added in the next PR (WCI-893).
Ticket: WCI-895
Session-Id: 4df43c40-1cea-4bcc-ae92-080304169427
Task-Id: 04666b37-650f-4c07-97b0-76a62e98f1ad
bitgo-ai-agent-dev
Bot
force-pushed
the
WCI-895-eddsa-mpcv2-keygen-callback-factory-pt1
branch
2 times, most recently
from
0b9c357 to
c13f9e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
EddsaMPCv2KeyGenInitializeRequestType,EddsaMPCv2KeyGenRound1RequestType, andEddsaMPCv2KeyGenFinalizeRequestTypeio-ts types toadvancedWalletManagerApiSpec.tsAdvancedWalletManagerApiSpec:POST /api/{coin}/eddsampcv2/keygen/initializePOST /api/{coin}/eddsampcv2/keygen/round1POST /api/{coin}/eddsampcv2/keygen/finalizecreateKeyGenRouterwith aNotImplementedErrorstub (real handlers land in WCI-892)Why
Test plan
npm run tsc -- --noEmitpassesnpm test— all 400 existing tests passStack
This PR is part 1 of 2 in a stack. Review and merge in order:
master) ← you are herept1)Ticket: WCI-895