Improve packaged build, skill ACL, and config compatibility#33
Closed
Lixtt wants to merge 3 commits into
Closed
Conversation
Contributor
Author
|
Closed in favor of #34 with neutral branch and title naming. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
a3s-commoncrate so standaloneCodecheckouts and Python wheel builds do not require a sibling../../commoncheckout.allowed-toolshandling compatible with omitted values, whitespace-only legacy values such asRead Write Edit Bash, and YAML list values.limitblocks, including snake_case and camelCase aliases.Why
These changes make packaged installs and benchmark/task catalogs work without relying on local build patches. They preserve explicit skill allowlists while avoiding accidental deny-all behavior for skills that omit
allowed-tools, and they allow long-context OpenAI-compatible model deployments to express output/context limits in ACL config.Validation
cargo test -p a3s-code-core test_config_supports_acl_style_provider_labelscargo test -p a3s-code-core test_parse_legacy_whitespace_allowed_toolscargo test -p a3s-code-core test_parse_allowed_tools_yaml_listcargo test -p a3s-code-core test_skill_permission_policy_allows_when_unspecifiedcargo test -p a3s-code-core test_skill_permission_policy_accepts_legacy_allowed_toolscargo test -p a3s-code-core test_config_parses_acl_model_token_limits